metaborg / spoofax-pie

Spoofax implementation using PIE pipelines
Apache License 2.0
12 stars 9 forks source link

SDF3 files in subdirectories can cause the parenthesizer file to not import the correct signatures, causing build errors #61

Closed Gohla closed 3 years ago

Gohla commented 3 years ago

Summary

SDF3 files in subdirectories can cause the parenthesizer file to not import the correct signatures, causing build errors.

What you did

Put syntax in subdirectories and build the language project.

What you expected to happen

Building to succeed.

What actually happened

Build fails with errors in in the generated parenthesizer file.

Context

Additional information

Commit from student that reproduces the problem: https://gitlab.ewi.tudelft.nl/CS4200/2021-2022/student-njkyu/-/commit/44d4d4f09f161a5702dbc17afdce8db7625468de

Gohla commented 3 years ago

Fixed by https://github.com/metaborg/sdf/commit/1c9e255a9e215582f0239aed6e66a1da38013851 and https://github.com/metaborg/spoofax-pie/commit/f2012a6cc2afdcb092d01aa4d32c9be8046d364d, to be released in the next release.