chore: Make redis, postgres and rabbitmq hosts configurable via env variables

metabrainz / musicbrainz-docker

Docker Compose project for the MusicBrainz Server with replication, search, and development setup

https://musicbrainz.org/doc/MusicBrainz_Server/Setup

284 stars 72 forks source link

chore: Make redis, postgres and rabbitmq hosts configurable via env variables #264

Closed lotooo closed 3 months ago

lotooo commented 6 months ago

I am trying to deploy our musicbrainz mirror in kubernetes using an external DB.

This PR updates the config files to read the db,redis,mq hosts from env variables and default them to the current value

lotooo commented 5 months ago

Thanks for the feedback !

doesn't need be changed as these stay the default values so it's fine to let them exist with the static name in the docker-compsoe file.
I update the README.

Working on the 2. now.

lotooo commented 5 months ago

For 2, I read those scripts (I just checked the one in the output of git grep -Pw 'db|mq|redis' admin/) and all of them are meant to be used locally and connect using docker-compose so there shouldn't have any impact (as the hosts name and the depends_on is not changed in the docker-compose.yml).

tldr; I don't think any of them has to be changed as they are not included in the Docker image and not meant to be executed from inside any of the containers.