search

metabrainz / picard-plugins

Picard plugins: use 1.0 branch for Picard < 2.0 (python 2/Qt4) and 2.0 branch for Picard >= 2.0 (python 3/Qt5)
https://picard.musicbrainz.org/plugins/
144 stars 93 forks source link

Replaygain 2.0 only usable in "releases" pane #344

Open tacuna opened 1 year ago

tacuna commented 1 year ago

As per https://community.metabrainz.org/t/how-do-i-run-the-replay-gain-2-0-plugin-in-picard/611697/3 i noticed you can only use the Replaygain 2.0 plugin when your song is part of a release. This is a deviation from the original plug-in, which i could on local files in the "right" pane (see screenshots in linked issue, i'm not the OP).

It might be my ignorance but the Replaygain 2.0 does not seem to work well for my use-case, selecting files > calc Replaygain + calc BPM from the Plugins context menu. I manage tags manually.

Can the Replaygain 2.0 plugin please also be enabled on the "right" pane?

phw commented 1 year ago

This was actually by design, but this can be reconsidered. Please see the following discussion for some background:

https://github.com/metabrainz/picard-plugins/pull/336#discussion_r980509606

@complexlogic What's your take on this?

complexlogic commented 1 year ago

@phw I remember we discussed whether or not to support the file mode before the initial release of the plugin. I thought it wasn't necessary, but I may have underestimated the number of Picard users that manually tag files because several people have now requested this feature. @tacuna is right that it is a loss of functionality, because the original ReplayGain plugin did support the file mode.

Perhaps it would be worthwhile to add support for the file and cluster plugin actions. To do that, we need to refactor the plugin to operate on the Picard File object, instead of Track. This would require a moderate amount of work.

I'm currently busy working on another project, but I may revisit this in a month or two. Of course, anybody else that wants to work on adding this feature is welcome to do so.

Xerpocalypse commented 3 months ago

Hello,

I know this is an older issue, but as someone who recently discovered Picard and who doesn't necessarily want to immediately commit to Picard's tags, I'd greatly appreciate the ability to use it only to apply ReplayGain.