search

metabrainz / picard-plugins

Picard plugins: use 1.0 branch for Picard < 2.0 (python 2/Qt4) and 2.0 branch for Picard >= 2.0 (python 3/Qt5)
https://picard.musicbrainz.org/plugins/
145 stars 95 forks source link

CoverArt Post Processing #347

Closed Pranay-Pandey closed 1 week ago

Pranay-Pandey commented 1 year ago

Check all the images in the metadata of track. Remove Image form the metadata if dimension less than minimum threshold. Resize the image if larger than maximum dimension. Requires Pillow library to be installed.

Sophist-UK commented 1 year ago

@Pranay-Pandey

Can I suggest that you add some unit tests to check each aspect of the plugin's intended functionality. (There is a GitHub workflow to run tests.)

In particular, I think that having tests to download the plugin and then to check that PIL is downloaded and accessible would be beneficial.

phw commented 1 year ago

@Pranay-Pandey Sorry for the long delay from my side here, I had been mostly unavailable the last few weeks.

Thanks a lot for this plugin. Overall this looks good to me except for the comments already done above. Given the current limitations of Picard's cover art handling this plugin works quite well.

I just wonder if it is a good approach to merge this now. Maybe we should rather see this plugin as a testbed for actually implementing this functionality inside Picard properly Your GSoC proposal is much more detailed and would allow a better implementation anyway.

Essentially we need to run the image processing directly after images have been actually loaded, and using a track metadata processor is kind of a workaround. Also it runs for each track, which is wasteful.

Sophist-UK commented 1 year ago

If this is going ahead as a GSoC project in main Picard, then I would support Philipp's reasons that we avoid merging this.

Pranay-Pandey commented 1 year ago

Thank you for your feedback and for considering my proposal. I completely understand your decision to not merge the pull request at this time, and I am looking forward to working on the project during GSoC.

zas commented 1 year ago

@Pranay-Pandey are you on #metabrainz? as who?

Pranay-Pandey commented 1 year ago

@Pranay-Pandey are you on #metabrainz? as who?

As pranay_pandey. Here is my profile - https://community.metabrainz.org/u/pranay_pandey

rdswift commented 1 year ago

@Pranay-Pandey are you on #metabrainz? as who?

As pranay_pandey. Here is my profile - https://community.metabrainz.org/u/pranay_pandey

I think @zas was asking if you're connected to the #metabrainz channel on IRC, which is where much of the developer communications happens.

Pranay-Pandey commented 1 year ago

Thanks for telling me about the #metabrainz channel on IRC. I joined using this name and am eager to contribute to the project and connect with the community.

zas commented 1 year ago

Thanks for telling me about the #metabrainz channel on IRC. I joined using this name and am eager to contribute to the project and connect with the community.

Under which nick are you on #metabrainz ? During the GSoC you have to be around so you can discuss with the Picard team.

Pranay-Pandey commented 1 year ago

Thanks for telling me about the #metabrainz channel on IRC. I joined using this name and am eager to contribute to the project and connect with the community.

Under which nick are you on #metabrainz ? During the GSoC you have to be around so you can discuss with the Picard team.

My nickname is pranay