search

metabrainz / picard-plugins

Picard plugins: use 1.0 branch for Picard < 2.0 (python 2/Qt4) and 2.0 branch for Picard >= 2.0 (python 3/Qt5)
https://picard.musicbrainz.org/plugins/
145 stars 94 forks source link

Fixes for "Generate M3U playlist" #245 , along with all reviews required #366

Closed sambhavnoobcoder closed 8 months ago

sambhavnoobcoder commented 8 months ago

fixes #245

made changes in the playlist.py to accommodate default playlist location to also work for multiple album selections. also takes into account the review changes from the past pr and makes sure that all necessary reviews from the last pr are accommodated in this pr .

sambhavnoobcoder commented 8 months ago

@phw kindly look into this and if any more changes are required , inform me of the same , i'll make them as well , and If it meets requirements , kindly merge the same .

phw commented 8 months ago

@sambhavnoobcoder Thanks a lot for this. I'll look over this in detail later today.

sambhavnoobcoder commented 8 months ago

this pr seems to have an issue ,as there are some other commits with it as well, ill close this pr and raise another pr with only the commit for this issue