search

metabrainz / picard-plugins

Picard plugins: use 1.0 branch for Picard < 2.0 (python 2/Qt4) and 2.0 branch for Picard >= 2.0 (python 3/Qt5)
https://picard.musicbrainz.org/plugins/
145 stars 95 forks source link

pr fixing issue exception when artist sorted name has no last name pa… #367

Open sambhavnoobcoder opened 10 months ago

sambhavnoobcoder commented 10 months ago

…rt issue#350

fixes #350

added conditional , that recognises a single word artist name different from one with a last name .In such cases, the code generates initials for this single word to serve as an abbreviated representation.The initials are formed by taking the first letter of each part of the single word and appending a dot ('.') after each letter.

moreover the code also handles the whitespaces in sorted and unsorted names .

sambhavnoobcoder commented 10 months ago

okay , I'll take this into account and redraft smaller pr's in a systematic manner to make it easier to review and more step by step to resolve any issues in the code as well . in doing so , I'll also provide with the adequate testing use cases for both before and after the changes to assist with testing the changes in the code . thanks .

phw commented 10 months ago

@sambhavnoobcoder Yes, that would be great. I find this a bit difficult to review as it is, but you already had to wrap you head around all the functionality here. Especially some real test cases, if you have some, would be useful.

eharris commented 5 months ago

I would love to see this get fixed, having quite a few errors with this plugin.