change to scripts installation instead of manual deps and flags and code improvement in general

metacall / builder

An advanced build system based on Buildkit in order to generate compact Docker images with MetaCall runtime.

Apache License 2.0

4 stars 7 forks source link

change to scripts installation instead of manual deps and flags and code improvement in general #20

Closed ashpect closed 3 weeks ago

ashpect commented 3 months ago

Changes Summery :

Changed structure to having 3 subcommands dev, deps and runtime for 3 kind of images.
For flags, made a new file flags.go to store all flags and had functions written to set flags.
Exported struct and making variable when needed.
Also created dep/dev options struct which get passed down the cli func, is way better if we want to add ui cli libraries later.
Changed manual work to running metacall scripts.

Example Usage : "builder runtime -b develop --cli nodejs typescript go rust wasm java c cobol", (will create a runtime image with metacall cli installed)

viferga commented 3 months ago

@ashpect can you resolve the conflicts? apparently cmd/builder/dev.go has some.

ashpect commented 3 months ago

@viferga resolved

ashpect commented 3 months ago

@viferga Pls review whenever you get time.

viferga commented 2 months ago

@ashpect I was checking your code after your request, and I don't feel it is able to be merged yet. I can have a review of it and maybe adapt some parts. Then we can merge it. Another option is to create a new branch and work on it if you want, if you really require it to be merged.

ashpect commented 1 month ago

cleaned + fixed some bugs we can build images for deps and dev. linux images on linux and arm images on macOS-m1