metacall / core

MetaCall: The ultimate polyglot programming experience.
https://metacall.io
Apache License 2.0
1.57k stars 160 forks source link

Wasm Windows CI #431

Closed pkspyder007 closed 1 year ago

pkspyder007 commented 1 year ago

This adds wasm to windows ci along with few fixes

viferga commented 1 year ago

The code is wrong, the malloc is leaking, you need a free? Is windows giving errors for variable length arrays?

pkspyder007 commented 1 year ago

Yes the compiler was throwing error for non constant array size. I don't have idea about the malloc leaking I am calling free at the end.

pkspyder007 commented 1 year ago

Something I found with wasm on windows 1- Unknown array length error 2- func i32_f32_i64_f64_ret_i32_f32_i64_f64 is retuning invalid result in test 3- scripts are not being loaded properly, e.g. empty_module.wasm is loaded from Debug folder not from script path 4- wasmtime dll and lib not being copied to build output

viferga commented 1 year ago

Solved.