search

metacall / deploy

Tool for deploying into MetaCall FaaS platform.
https://dashboard.metacall.io
Apache License 2.0
18 stars 29 forks source link

Inspect validation #152

Open diaabadr opened 1 year ago

diaabadr commented 1 year ago

@viferga I have added the new updates on the master branch with the ensureDeploymentsExist

viferga commented 1 year ago

I don't know why but many tests are failing, you should review them, otherwise we cannot merge this. I'm setting this PR as a draft until it passes the tests.

diaabadr commented 1 year ago

@viferga I think they are failing because of the secrets. workflows on a pull requests doesn't have access to the secrets. when i run it on my forked repo it passes the tests that doesn't require plans such as login, inspect, etc. my account doesn't have plans to test deploy, delete, etc. that's the reason they are failing here

image

It sees my secrets in my forked repo

image

but it doesn't see base repo secrets in the pr workflow

image

I think that's the problem. what do you see?

diaabadr commented 1 year ago

I have added extra validation at the login with email and password flags. if the email and password are empty. the CLI asks for login with the auth choices (token or email). it doesn't consider them as invalid credentials so it doesn't throw an error to catch it and fail the login test. so i added a check on the info messages if it includes login successful or not.

viferga commented 2 months ago

@diaabadr I re-run the tests by doing a small change in the code, and they failed. You can review now and solve the issues if you want, meanwhile I am going to leave this PR as a draft.