metacall / faas

Reimplementation of MetaCall FaaS platform written in TypeScript.
https://dashboard.metacall.io
Apache License 2.0
13 stars 20 forks source link

refactor: tackle corner cases and change variable names for better readability #38

Closed khareyash05 closed 4 months ago

khareyash05 commented 4 months ago

Signed-off-by: Yash yash2010118@akgec.ac.in

viferga commented 4 months ago

@khareyash05 for me it seems correct, I do not understand what @Creatoon said respect to the error messages. Can you update the conflicts to make it work again with the latest changes?

Once you do that I will merge your PR.

khareyash05 commented 4 months ago

@khareyash05 for me it seems correct, I do not understand what @Creatoon said respect to the error messages. Can you update the conflicts to make it work again with the latest changes?

Once you do that I will merge your PR.

Resolved the conflicts. Maybe we are unable to comprehend what @Creatoon wants to say. If there is something I might be missing. Let me know. Thanks @viferga

viferga commented 4 months ago

I passed the CI and after my change of considering all warnings as errors (of the linter), your CI execution failed: https://github.com/metacall/faas/actions/runs/8294111642/job/22775896259?pr=38

Correct this linter issue and I will merge it.

khareyash05 commented 4 months ago

I passed the CI and after my change of considering all warnings as errors (of the linter), your CI execution failed: https://github.com/metacall/faas/actions/runs/8294111642/job/22775896259?pr=38

Correct this linter issue and I will merge it.

fixed. Kindly rerun the CI

giarve commented 4 months ago

I passed the CI and after my change of considering all warnings as errors (of the linter), your CI execution failed: https://github.com/metacall/faas/actions/runs/8294111642/job/22775896259?pr=38 Correct this linter issue and I will merge it.

fixed. Kindly rerun the CI

Done, sorry for the long wait

viferga commented 4 months ago

@khareyash05 seems to be still failing.

viferga commented 4 months ago

I am merging this and I will solve the issues by myself.

khareyash05 commented 4 months ago

Thanks @viferga .