metacall / install

Cross-platform set of script to install MetaCall infrastructure.
https://metacall.io
Apache License 2.0
12 stars 12 forks source link

Installation issue [NixOS] #3

Closed Creator54 closed 2 years ago

Creator54 commented 3 years ago

share

giarve commented 3 years ago

Instead of modifying /etc/profile (which is global and readonly in the case of NixOS, as expected) we should add a new file under /etc/profile.d because the line added is application specific and check if the shell is fish because the exporting of the variables is different than other shells (bash, zsh..).

Creator54 commented 3 years ago

As per /etc/profile it doesnt seem to check for the profile.d dir so I appended to profile.local seems to works only with bash shell. share

viferga commented 2 years ago

@Creator54 Sorry for late reply, I did not notice about this issue. Here's the patch: https://github.com/metacall/install/commit/e07ae8b27a66916769977c3eb7a50f7d8e1614a4