metaclass-nl / filter-bundle

Filter bundle for API Platform, Filter Logic
MIT License
50 stars 9 forks source link

when no where filter is used, do not replace inner joins by left joins #15

Closed metaclass-nl closed 2 years ago

metaclass-nl commented 2 years ago

The readme says "existing requests keep working unmodified if not using "and", "or" or "not" as query parameters". The chapter "Nested properties workaround" does not make an exception for innerJoinsLeft, so it should not change any joins if not using "and", "or" or "not" as query parameters.

It doesn't either for AddFakeLeftJoin but that is a seperate filter so it can be expected that it will not react to the query parameters of FilterLogic ("and", "or" or "not").