metacpan / MetaCPAN-Client

Home of the official MetaCPAN Perl API client.
21 stars 23 forks source link

Undeclared dependency LWP::Protocol::https #79

Closed eserte closed 7 years ago

eserte commented 7 years ago

It seems that LWP::Protocol::https has to be declared as a prerequisite:

Use of uninitialized value in concatenation (.) or string at /home/cpansand/.cpan/build/2017032321/HTTP-Tiny-0.070-zFPGrC/blib/lib/HTTP/Tiny.pm line 593.

#   Failed test 'No illegal methods called'
#   at t/ua_trap.t line 45.
#          got: 'Failed to fetch 'https://fastapi.metacpan.org/v1//author/KENTNL': Protocol scheme 'https' is not supported (LWP::Protocol::https not installed) at /tmpfs/.cpan-build-cpansand/2017032321/MetaCPAN-Client-2.008001-Syu199/blib/lib/MetaCPAN/Client.pm line 212.
# '
#     expected: undef
# Failed to fetch 'https://fastapi.metacpan.org/v1//author/KENTNL': Protocol scheme 'https' is not supported (LWP::Protocol::https not installed) at /tmpfs/.cpan-build-cpansand/2017032321/MetaCPAN-Client-2.008001-Syu199/blib/lib/MetaCPAN/Client.pm line 212.
# Looks like you failed 1 test of 1.
t/ua_trap.t ............. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/1 subtests 
mickeyn commented 7 years ago

hmm... the cpanfile does have:

on 'test' => sub {
  ...
  recommends "LWP::Protocol::https" => "0";
  ...
};

@oalders should that be changed to requires?

oalders commented 7 years ago

@mickeyn yes, that should be requires. Also, I'm wondering why the URL in the example above has double slashes in the path https://fastapi.metacpan.org/v1//author/KENTNL

mickeyn commented 7 years ago

k, will change that. i'll remove the extra slash (i just touched that code today to remove the v1 - that came from looking at the same url :))

mickeyn commented 7 years ago

@eserte I just released 2.00900 with the fix, please let me know if it's better now.

mickeyn commented 7 years ago

~@oalders any idea why that still wouldn't work?~ wrong ticket :)

eserte commented 7 years ago

I think I didn't see this type of error anymore. So assuming it's fixed.