search

metacraft-labs / DendrETH

A smart contract implementation of the Ethereum light client sync protocol
GNU General Public License v3.0
45 stars 9 forks source link

Integrate starky in dendreth #317

Closed Dimo99 closed 4 months ago

smanilov commented 4 months ago

I ran most binaries and they seem to run successfully, although it is unclear why some run faster and others don't.

I took a look at the code and it seems this PR mainly pipes things together and adds some serialization/deserialization code. There is a lot of repetition, which made it possible to go through the large volume of code in a rather short time.

Given that we are short on time, I'd say this PR could be merged as it is. My biggest wish would be to have the binaries as tests instead, so that testing the PR could be automated.

Please wait for @NikolayKostadinov21 's review before merging, as he can give more in-depth comments.

NikolayKostadinov21 commented 4 months ago

I also believe that merging this PR is the best decision since I don't spot any issues related to the logic or functional inaccuracies. In a follow-up branch, I will address all the improvements that I believe should be applied.