metacran / metacranweb

Web pages for metacran
http://www.r-pkg.org
13 stars 6 forks source link

Rendering Quarto reveal.js only "Not Published" badges #122

Closed adamhsparks closed 5 months ago

adamhsparks commented 5 months ago

I'm attempting to use badges in a reveal.js slide deck in Quarto but I only ever get the "Not Published" image in the knitted deck, e.g., using https://www.r-pkg.org/badges/version/agricolae as the image source only returns the bronze "Not Published" badge, not the green version number that this link points to.

For most of the packages in the slide deck that I'm talking about, it's true, but for this one, I'd like to be able to indicate it's on CRAN.

gaborcsardi commented 5 months ago

That badge looks good to me. Does it look ok to you if you click on it here?

adamhsparks commented 5 months ago

Sorry, I wasn't clear. It looks ok here and if I click on it from the presentation. However, IN the presentation it's the incorrect badge that's shown no matter what I do. Clicking on it in the reveal.js presentation slides takes me to the proper green one but the reveal.js presentation HTML displays the "Not on CRAN" for any/all packages when rendered.

gaborcsardi commented 5 months ago

That does not seem like a problem with the server. It is also pretty hard to guess what is wrong without seeing the actual presentation.

adamhsparks commented 5 months ago
Screenshot 2024-04-02 at 15 36 49

OK, here's an example with one not on CRAN and one that is on CRAN.

https://github.com/adamhsparks/test_qmd

Hopefully this helps.

gaborcsardi commented 5 months ago

The link is incorrect here: https://github.com/adamhsparks/test_qmd/blob/main/test_qmd.html#L351

gaborcsardi commented 5 months ago

See https://github.com/quarto-dev/quarto-cli/issues/6092

adamhsparks commented 5 months ago

w00t! Thank you, @gaborcsardi!!! That issue you pointed me at allowed me to fix it, easy as.