metadata101 / iso19139.ca.HNAP

ISO Harmonized North American Profile (HNAP)
GNU General Public License v2.0
4 stars 19 forks source link

Update iso19139.ca.HNAP.FGP-to-iso19139.ca.HNAP.xsl #284

Closed wangf1122 closed 1 year ago

wangf1122 commented 1 year ago

During iso19139.ca.HNAP.FGP-to-iso19139.ca.HNAP conversion when importing metadata, the resource name in the thumbnail is missing. image

Therefore, current schematron validation will fail image

After the fix, the default name will be added

image

No more validation error on thumbnail part. image

ianwallen commented 1 year ago

Related to #92 but does not really fix the problem

ianwallen commented 1 year ago

In some cases the data is as follows.

         <gmd:graphicOverview xlink:role="urn:xml:lang:fra-CAN">
         </gmd:graphicOverview>
         <gmd:graphicOverview xlink:role="urn:xml:lang:eng-CAN">
         </gmd:graphicOverview>

In these cases, the language is based on the urn:xml:lang - so the English and French will be in separate records.

But your fix seems to be simply adding the missing gmd:PT_FreeText which seems to match the concept used in existing FGP records.

So what you are proposing seems to be a partial fix but I wonder if the fix should be done on the existing FGP data?

@josegar74, @bo-lu do you have any comments about the missing gmd:PT_FreeText in FGP data?

bo-lu commented 1 year ago

I'm not too sure what is appropriate here as I am overall not too concerned since the thumbnails are not displayed on Open Maps. It is an optional field (nullable) but if it is non-null then both English and French text must be provided.

As you point out, there are a lot of records with missing values in FGP while the editor now writes null values. We can explore an upgrade of FGP records to include missing gmd:PT_FreeText, but my preference is to have it completed via an SQL query (after a lot of testing).