Closed wangf1122 closed 1 year ago
Related to #92 but does not really fix the problem
In some cases the data is as follows.
<gmd:graphicOverview xlink:role="urn:xml:lang:fra-CAN">
</gmd:graphicOverview>
<gmd:graphicOverview xlink:role="urn:xml:lang:eng-CAN">
</gmd:graphicOverview>
In these cases, the language is based on the urn:xml:lang - so the English and French will be in separate records.
But your fix seems to be simply adding the missing gmd:PT_FreeText which seems to match the concept used in existing FGP records.
So what you are proposing seems to be a partial fix but I wonder if the fix should be done on the existing FGP data?
@josegar74, @bo-lu do you have any comments about the missing gmd:PT_FreeText in FGP data?
I'm not too sure what is appropriate here as I am overall not too concerned since the thumbnails are not displayed on Open Maps. It is an optional field (nullable) but if it is non-null then both English and French text must be provided.
As you point out, there are a lot of records with missing values in FGP while the editor now writes null values. We can explore an upgrade of FGP records to include missing gmd:PT_FreeText, but my preference is to have it completed via an SQL query (after a lot of testing).
During iso19139.ca.HNAP.FGP-to-iso19139.ca.HNAP conversion when importing metadata, the resource name in the thumbnail is missing.![image](https://user-images.githubusercontent.com/74916635/190234650-564fc3d0-9165-4fb0-a407-d2a272dd3562.png)
Therefore, current schematron validation will fail![image](https://user-images.githubusercontent.com/74916635/190234745-775fc0e5-dc21-4630-8d1c-378ee4fc243d.png)
After the fix, the default name will be added
No more validation error on thumbnail part.![image](https://user-images.githubusercontent.com/74916635/190235085-0af939ef-a06f-463a-93bb-6a482ef1c50a.png)