metadata101 / iso19139.ca.HNAP

ISO Harmonized North American Profile (HNAP)
GNU General Public License v2.0
4 stars 19 forks source link

gmd:distributionFormat value seems to be incorrect. #319

Open ianwallen opened 1 year ago

ianwallen commented 1 year ago

FGP shows the following which uses the code in the

<gmd:distributionFormat>
            <gmd:MD_Format>
               <gmd:name>
                  <gco:CharacterString>CDED ASCII</gco:CharacterString>
               </gmd:name>
               <gmd:version>
                  <gco:CharacterString>test</gco:CharacterString>
               </gmd:version>
            </gmd:MD_Format>
         </gmd:distributionFormat>

Our System shows the following which uses the language value in the This is incorrect because if this is what is supposed to be there then we would also require the translated text and it does not have the translated text

<gmd:distributionFormat>
            <gmd:MD_Format>
               <gmd:name>
                  <gco:CharacterString>ASCII (CDED)</gco:CharacterString>
               </gmd:name>
               <gmd:version>
                  <gco:CharacterString>test</gco:CharacterString>
               </gmd:version>
            </gmd:MD_Format>
         </gmd:distributionFormat>

So there bug seems to be related to the editor/validator that should be using codes to follow FGP Or both English and French values should exists.

ianwallen commented 1 year ago

Another issue with current setup is that is set based on the main language. But the value set is based on English.

image

This is because it tries to compare the french value to the english value.

It is better if is use codes instead to be consistent

ianwallen commented 1 year ago

According to https://github.com/metadata101/schemas/blob/de-geogratis/hnap/2.3.1/HNAP.md#clause-51131-name It says that the values need to be https://www.gcpedia.gc.ca/wiki/Federal_Geospatial_Platform/Policies_and_Standards/Catalogue/Release/Appendix_B_Guidelines_and_Best_Practices/Guide_to_Harmonized_ISO_19115:2003_NAP/Format?setlang=en&uselang=en But these are all the English values within the src/main/config/codelist/local/thesauri/theme/GC_Resource_Formats.rdf Switching to the French does not change the codes. This seems like a bug in the documentation as it does not make sense to use English values - codes exists and are language independent.

FGP Excel Spreadsheet seems to have the correct codes as the following. image

bo-lu commented 1 year ago

Hi Ian, I think it is best to keep the code value since it would require quite a bit of change for us. The application can convert these code to the bilingual value. Also, there is no clear direction from the policy side.