metadata101 / iso19139.ca.HNAP

ISO Harmonized North American Profile (HNAP)
GNU General Public License v2.0
4 stars 19 forks source link

Use dates from the thesaurus file if exists instead of file system last modified date from thesaurusDate #327

Closed wangf1122 closed 1 year ago

wangf1122 commented 1 year ago

This is to fix the issue https://github.com/metadata101/iso19139.ca.HNAP/issues/308

Also depends on this PR https://github.com/geonetwork/core-geonetwork/pull/6972

Once Geonetwork passed isFilesystemDate flag into the HNAP schema. HNAP will be able to parse it or discard it.

ianwallen commented 1 year ago

Related to #329

josegar74 commented 1 year ago

Probably relevant to update https://github.com/metadata101/iso19139.ca.HNAP/blob/3.12.x/src/main/config/codelist/local/thesauri/theme/GC_Core_Subject.rdf as part of this pull request with the relevant dates.

wangf1122 commented 1 year ago

Yes, the thesaurus file itself needs to be updated. I was thinking to do in a separate PR or if you prefer, I can do into this PR. I am also trying to define what date to put into this file.

ianwallen commented 1 year ago

@josegar74

Probably relevant to update https://github.com/metadata101/iso19139.ca.HNAP/blob/3.12.x/src/main/config/codelist/local/thesauri/theme/GC_Core_Subject.rdf as part of this pull request with the relevant dates.

This is related to the following issue Related to https://github.com/metadata101/iso19139.ca.HNAP/issues/329

Once the correct date is identified then we can create a new PR to apply the changes.

ianwallen commented 1 year ago

If we don't want to wait for related issue https://github.com/metadata101/iso19139.ca.HNAP/issues/329 , then we can do as @josegar74 suggested and just use the existing values. And when issue #329 identifies the correct dates then we can create another PR to apply the correct dates.

      <dcterms:issued>2004</dcterms:issued>
      <dcterms:created>2016-07-04</dcterms:created>
wangf1122 commented 1 year ago

I added the default date to the GC_Core thesaurus file. Also group the logics to a single function. Tested and works fine. @ianwallen