Closed wangf1122 closed 1 year ago
@josegar74 @ianwallen
I made one more commit to reorder the [gmd:dataQualityInfo] after the gmd:distributionInfo according to this http://www.datypic.com/sc/niem21/t-gmd_MD_Metadata_Type.html
Please take a look
Checking the code the process relies in this process: https://github.com/geonetwork/core-geonetwork/blob/3.12.x/schemas/iso19139/src/main/plugin/iso19139/process/source-add.xsl#L56-L64
I think would be better to fix it instead of updating the inflate process of HNAP.
Also about the templates, I don't think they need to be changed?
Checking the code the process relies in this process: https://github.com/geonetwork/core-geonetwork/blob/3.12.x/schemas/iso19139/src/main/plugin/iso19139/process/source-add.xsl#L56-L64
I think would be better to fix it instead of updating the inflate process of HNAP.
Also about the templates, I don't think they need to be changed?
Hi @josegar74
Yes, I tested the code in ISO13139 and it works fine. I created a PR to replace this one
@josegar74
I created this PR for the source-add.xsl as we discussed the codeList of ISO13139 is different. So we should better created from HNAP schema level. Here is the PR: https://github.com/metadata101/iso19139.ca.HNAP/pull/331
Closing this PR, replaced by #331.
The current template has no such gmd:dataQualityInfo therefore all metadata created are lack of this section. When the user click on "link to a source dataset"![image](https://user-images.githubusercontent.com/74916635/233385435-4cbaf443-da04-40ac-943a-09eb06ea2273.png)
Geonetwork will add such section into the metadata. However it wasn't added correctly. The required gmd:scope is missing according to the schema https://github.com/metadata101/iso19139.ca.HNAP/blob/14ead08ef492220fb5d7a6e8c22022807b941201/src/main/plugin/iso19139.ca.HNAP/schema/gmd/dataQuality.xsd#L505
As result, the schema validation will fail![image](https://user-images.githubusercontent.com/74916635/233386126-0d38087c-4b28-4760-8983-7f59d37ab856.png)
This PR will ensure to inflate existing missing gmd:dataQualityInfo also add it to the template. It is backwards compatible by testing with both existing data and adding new data.