metadata101 / iso19139.ca.HNAP

ISO Harmonized North American Profile (HNAP)
GNU General Public License v2.0
4 stars 19 forks source link

HNAP specific keyword types are displayed as a key in the geonetwork 4.2 default view #385

Open tylerjmchugh opened 5 months ago

tylerjmchugh commented 5 months ago

Keywords with keyword types that are specific to HNAP (product, subTopicCategory) display the key instead of the translated string.

image

core-geonetwork has:

"otherKeywords-place": "Place",
"otherKeywords-discipline": "Discipline",
"otherKeywords-stratum": "Stratum",
"otherKeywords-temporal": "Temporal",
"otherKeywords-theme": "Theme",
"otherKeywords-": "Keywords",

https://github.com/geonetwork/core-geonetwork/blob/7caa17e47751870e5912a2788ec6835046f8e4e7/web-ui/src/main/resources/catalog/locales/en-v4.json#L8-L13

But there is no equivalent for HNAP keyword types:

"otherKeywords-product": "Product",
"otherKeywords-subTopicCategory": "Subtopic Category",
ianwallen commented 5 months ago

Isn't this supposed to be the translation

https://github.com/metadata101/iso19139.ca.HNAP/blob/133229ef1bf15b1a814af03462b09c65f2493ef0/src/main/plugin/iso19139.ca.HNAP/loc/eng/codelists.xml#L1278-L1290

tylerjmchugh commented 5 months ago

Isn't this supposed to be the translation

https://github.com/metadata101/iso19139.ca.HNAP/blob/133229ef1bf15b1a814af03462b09c65f2493ef0/src/main/plugin/iso19139.ca.HNAP/loc/eng/codelists.xml#L1278-L1290

@ianwallen For the full view, yes. But the index (containing otherKeywords-* keys) seems to be used for the default view instead of codelists.

josegar74 commented 5 months ago

You can go to https://SERVER/geonetwork/srv/eng/admin.console#/settings/languages and add the translation keys and values there.

I usually first remove all non relevant languages from the language list first. Probably in your case, you need only English and French.

ianwallen commented 5 months ago

We can apply that change for now but we should keep this ticket open so that we can apply a better solution in the future.