metadata101 / iso19139.ca.HNAP

ISO Harmonized North American Profile (HNAP)
GNU General Public License v2.0
4 stars 19 forks source link

Online Resource losing content while editing #66

Open geothorne opened 4 years ago

geothorne commented 4 years ago

for the online resource section of the editor the following behaviour is observed:

If you type the resource name info in English and/or French then choose or modify what was selected for protocol, the resource name information disappears and must be reentered. Is this the expected behaviour? Creates more work for user if they selected the wrong protocol to start.

@davidblasby comment - "It's a issue with the language management in the dialog, HNAP uses fra for french and seem not well managed."

davidblasby commented 4 years ago

This occurs ONLY when creating a new online resource.

When editing an existing one, its works as expected.

pvgenuchten commented 4 years ago

Maybe the behaviour was introduced to prevent people keeping a wms-layer reference in the name field while switching to the wfs protocol, the wms-layer reference may not be valid for that endpoint as wfs (convention in geonetwork is to use layer/featuretype/coverage reference in onlineresource/name property).

For example the endpoint https://geodata.rivm.nl/geoserver/dank/ows, for wms layers they are referenced as 'rivm_r21_20150805_pc_ChlorideDrinkwater' https://geodata.rivm.nl/geoserver/dank/ows?service=wms&request=getcapabilities wfs featuretypes are referenced as 'dank:rivm_r21_20150805_pc_ChlorideDrinkwater' https://geodata.rivm.nl/geoserver/dank/ows?service=wfs&request=getcapabilities

Although people will receive a warning in case the name has an incorrect value, so i'd be in favour of keeping the name content while switching protocol.

davidblasby commented 4 years ago

I will create an option to change the behaviour, and set "don't clear" as the default. It also deletes the "description" field as well.
It doesn't do this in "edit" mode, just in "add" mode.

davidblasby commented 4 years ago

https://github.com/geonetwork/core-geonetwork/pull/4894