metadatacenter-attic / phs-gdc

PHS-GDC Prototype
1 stars 0 forks source link

tweak UI variable language #38

Open graybeal opened 3 years ago

graybeal commented 3 years ago

In the UI, we have a little confusion stemming from word choices. This is fairly easily fixed, here is my suggestion:

Arguably it will be clearer the first time if there is no default radio button selected, and the box at the bottom isn't there. But it's mildly tricky to make obvious that the next step is to choose one of the radio buttons. (Maybe if we want to remove the box, then make the header of the radio selector section "Entering location values (choose one)"?)

Also, in box 2 suggest changing the following:

Screen Shot 2021-04-23 at 5.15.44 PM.png

marcosmro commented 3 years ago

Those suggestions look good to me. Just two comments:

graybeal commented 3 years ago

Yes. How about "Select locations we can use to look up data in Data Commons."

I'm not in love with showing both boxes, but it's the best of the options so far I agree. How about a checkbox that says "Use all values from entered US states", and the default is not checked? Checking the box changes the provided box and example. The title for the section is "Enter location values".

jvendetti commented 3 years ago

@marcosmro - I'm not certain I follow your proposal with regard to removal of the radio buttons. When you say:

Another alternative (which I prefer) would be to remove the radio button group and show by default both the "Select locations" dropdown the "Enter values" text box. The user wouldn't have to click on the radio button. He/she would just have to either enter the values into the text box or select one or several locations in the dropdown.

It sounds like you want the (recently renamed) "Location list" text area and "States" select box to appear in an enabled state simultaneously? It also sounds like you want to keep the paradigm that it's only valid to use one or the other component to narrow the query results? If so, what is your expectation if the the end user happens to enter something in both components?

With both components visible and enabled, I can imagine a thought process on the part of an end user where they might do something like:

In other words, execute a query that includes Santa Clara, CA, and all counties in the state of Arizona, aggregating my results by county.

marcosmro commented 3 years ago

Right, I agree. It's better to keep the radio buttons as they are, or think about a better alternative.