search

metadevpro / openapi3-ts

TS Model & utils for creating and exposing OpenAPI 3.x contracts.
MIT License
485 stars 64 forks source link

Revert #124 #128

Closed RobinTail closed 10 months ago

RobinTail commented 10 months ago

Fixes #127 This reverts #124, commit f1eb201fd5d39b41bb665706d35ce9b5a7775b4d.

Based on the findings within the issue #127 it turned out that the changes made in #124 are incorrect and caused by the fact that the examples property has different types in different interfaces.

There is no evidence that examples of SchemaObject is changed from array to object.

RobinTail commented 10 months ago

Meanwhile something is broken in the CI

> openapi3-ts@4.2.0 version
> node --version && npm --version && eslint --version && tsc --version && vite --version && vitest --version

v18.19.0
10.2.3
v8.56.0
Version 5.3.3
/home/runner/work/openapi3-ts/openapi3-ts/node_modules/rollup/dist/native.js:8[7](https://github.com/metadevpro/openapi3-ts/actions/runs/7294252975/job/19878780249?pr=128#step:4:8)
        throw new Error(
              ^

Error: Cannot find module @rollup/rollup-linux-x64-gnu. npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try `npm i` again after removing both package-lock.json and node_modules directory.

caused probably by vite --version

Below I'm doing exactly what is recommeded:

npm has a bug related to optional dependencies (https://github.com/npm/cli/issues/4828). Please try npm i again after removing both package-lock.json and node_modules directory.

RobinTail commented 10 months ago

@pjmolina , please review the revert of the examples type.

Unfortunately, I also had to recreate the lock file (there seem to be the bug of NPM) to make the CI running, and I installed the missing coverage reporter (v8). Let me know if you have other plans on fixing the CI or if you wanna split it into another PR.