Review code and tests - Githubissues

KevCaz commented 5 years ago

I do not have access to the API yet, so I review the code and the tests, I only change parts I was able to test, briefly this PR:

does not add any feature to the package;
adds a code of conduct (same as the one we used for rcites) see https://github.com/ibartomeus/traitbase/issues/11;
lists taxize and utils as imported package in DESCRIPTION (a couple of functions from these packages are called) see https://github.com/ibartomeus/traitbase/issues/19;
removes urlEncode() see https://github.com/ibartomeus/traitbase/issues/20;
shortens the code without losing readability and fixes a few typos;
reviews tests and add new ones for auxiliary functions ;
privateImport() is now in auxiliar.R;
removes all require("httr");
gets rid of one call to sapply() as it is not seen as good practice according to https://github.com/MangoTheCat/goodpractice.

ibartomeus commented 5 years ago

@KevCaz can I accept this pull request safely even if Travis build failed?

KevCaz commented 5 years ago

Well currently because the credential are not working, Travis fails.

So to answer your question, yes and as soon as I can get connected, I'll ensure everything works fine.

metadevpro / traitbaser