Closed KevCaz closed 5 years ago
May be we should wait till the issue with privateImport()
is solved so I can add the fix to this PR.
to_dataframe()
is now called toDataframe()
: it is siimpler and more efficient. So far only _links
columns is removed. Next will be to add helper function that parse this column.
:exclamation: No coverage uploaded for pull request base (
master@9b76bc0
). Click here to learn what that means. The diff coverage is42.35%
.
@@ Coverage Diff @@
## master #8 +/- ##
========================================
Coverage ? 28.8%
========================================
Files ? 12
Lines ? 184
Branches ? 0
========================================
Hits ? 53
Misses ? 131
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
R/cleanSpecies.R | 0% <ø> (ø) |
|
R/resource.R | 0% <ø> (ø) |
|
R/count.R | 0% <ø> (ø) |
|
R/validateDataset.R | 0% <ø> (ø) |
|
R/importDataset.R | 0% <ø> (ø) |
|
R/connect.R | 0% <0%> (ø) |
|
R/parseErrors.R | 0% <0%> (ø) |
|
R/set_login.R | 0% <0%> (ø) |
|
R/query.R | 0% <0%> (ø) |
|
R/queryRaw.R | 0% <0%> (ø) |
|
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 9b76bc0...5f06291. Read the comment docs.
I'll merge this as login works as expected.
This PR:
?set_login
):connect()
;So far all tests pass successfully but the ones that call
privateImport()
.