metadriverse / metadrive

MetaDrive: Open-source driving simulator
https://metadriverse.github.io/metadrive/
Apache License 2.0
815 stars 111 forks source link

Vehicle model in MA env #239

Closed 6Lackiu closed 2 years ago

6Lackiu commented 2 years ago

Hello, first of all thank you very much for making such a great simulator! I have a little problem, I want to use random vehicle model in MARL environment, but when I change vehicle_mode from "static_default" to "default " or "s", "m", "l", "xl", and run multi_agent_metadrive.py, nothing has changed, the vehicles are still the same model. Am I doing something wrong? Or where else do I need to change? Looking forward to your reply, thanks! image

QuanyiLi commented 2 years ago

Hi, Xiaoya,

Thanks for your feedback. It is a bug.

I fixed it and created a new PR #240 with the branch named marl-model. Could you pull and checkout to this new branch and test this function? I tested it by running python metadrive/envs/marl_envs/multi_agent_metadrive.py. At line 270 of this script, you can find how we specify the model for each agent.

If this works for you, I will merge it into the main branch. Feel free to create issues here, if any questions. We are happy to help you with them : )

Quanyi

6Lackiu commented 2 years ago

It works! Thanks for the quick fix! Really appreciate that.