search

metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.
https://metafacture.org
Apache License 2.0
69 stars 34 forks source link

Move AbstractLookup.java and AbstractCompose.java to helpers? #365

Closed TobiasNx closed 3 years ago

TobiasNx commented 3 years ago

AbstractCompose.java and AbstractLookup.java sit in the functions folder while the other "abstract"-helpers reside in https://github.com/metafacture/metafacture-core/blob/6f3a197ae99a77f00f17d69edb825365ba5a9fce/metamorph-api/src/main/java/org/metafacture/metamorph/api/helpers/

Is that intentional, should we move them?

fsteeg commented 3 years ago

As discussed in the standup today: I think the way it is makes sense, since the classes in the functions package relate to specific functions. Also, this would be a breaking change which we can only introduce in a major version.