Closed blackwinter closed 2 years ago
Oh well, looks like I've touched virtually every single Java file there is: 496/499 :exploding_head:
Uh, this is a lot of change ... hard to check everything.
Yes, sorry about that! But if it's any consolation, it was also a lot to write ;)
After my scanning I think it's good.
Thanks!
there are some tests changed - but it's just adding a newline before package declaration
I only applied very few automatic changes to the test sources.
Thanks for the review!
Oddly, I had to run
./gradlew editorconfigFormat
locally once (but resulting in no changes ongit diff
) to get rid of violation errors (whitespace/newline issues).
So you had local (unversioned) files that were checked? Would you want those to get excluded/ignored?
So you had local (unversioned) files that were checked? Would you want those to get excluded/ignored?
No, no unversioned files. Maybe related to line endings managed by git internally (core.autocrlf
)? No problem though, mostly a note in case anyone has the same issue locally.
Based on https://github.com/metafacture/metafacture-fix/blob/master/config/checkstyle/checkstyle.xml (metafacture/metafacture-fix#11).
_Originally posted by @fsteeg in https://github.com/metafacture/metafacture-core/pull/387#discussion_r701908944_
This would be part 2 (see #388 for part 1).
Notes:
checkstyle-disable-line
) should be evaluated; maybe adjust the Checkstyle config.MagicNumber
,MissingCtor
,ReturnCount