decode-csv: Header seems not to be default

metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.

https://metafacture.org

Apache License 2.0

69 stars 34 forks source link

decode-csv: Header seems not to be default #390

Closed TobiasNx closed 2 years ago

TobiasNx commented 3 years ago

When trying to decode-csv the option hasHeader is not "true" by default. This seems contrary to the the inline documentation and the documentation in flux-commands.md:

https://github.com/metafacture/metafacture-core/blob/57fd43022a43481eb3fe8b1c1d3ad348f06794af/metafacture-csv/src/main/java/org/metafacture/csv/CsvDecoder.java#L32

dr0i commented 3 years ago

You are right! Fixing the code would mean an API break so we should just fix the documentation.

TobiasNx commented 2 years ago

This seems to be fixed by @dr0i https://github.com/metafacture/metafacture-core/blob/27780befa4b3fceea7ef7f01348cb811f1ed6e80/metafacture-csv/src/main/java/org/metafacture/csv/CsvDecoder.java#L33

in: #396