metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.
https://metafacture.org
Apache License 2.0
71 stars 34 forks source link

Next release Metafacture core 5.3.1 #429

Closed dr0i closed 2 years ago

dr0i commented 2 years ago

Prepare next release 5.3.1.

First, this is about testing the Metafacture core 5.3.1rc. From #428:


This is the branch for testing metafacture-core release candidate 5.3.1. It follows up #397.

Based on the experience we've made with the release of metafacture-core 5.3.0 (which is deprecated resp. not recommended for usage) it was discussed with @blackwinter the need to better test release candidates before actually releasing them (this is also reflected now in the Maintainer Guidelines).

@blackwinter found the dependency upgrade of log4j:1.2.12' to log4j-core:2.14. problematic, so this is reverted in 36ed969.

I have tested 5.3.0 against lobid-resources and found an incompatibility which I reverted in 7c1ea04.

Furthermore, I found out that if you are using a metamorph.xsd of your own and make use of FileMap you have to also update your locally metamorph.xsd (like the one at https://github.com/hbz/lobid-resources/blob/master/src/main/resources/schemata/metamorph.xsd):

-      <attribute name="separator" type="string" use="optional" default="\t">
+      <attribute name="separator" type="string" use="optional" default="&#09;">

As this will occur only quite rarely (is there anybody out there using a local duplicate of metamorph.xsd ?) and this is the result of a bug fix (d528ac9) (in effect the default separator defined (falsely) in metamorph.xsd has had no effect at all) this "breaking" fix will be part of the release (or is anyone against this?) but the release would come with the here mentioned note.

dr0i commented 2 years ago

For testing the release candidate artifacts in maven or gradle.follow the instructions at https://github.com/metafacture/metafacture-core/wiki/Maintainer-Guidelines#making-a-release-candidate -> 9. ("candidate is available to be consumed").

The standalone can be tested by downloading https://github.com/metafacture/metafacture-core/releases/tag/untagged-8ac55fdd758acd7035b6.

dr0i commented 2 years ago

@hagbeck and @UBmakla: you are also encouraged to test this release candidate.

blackwinter commented 2 years ago

:+1: Tested feature-5.3.1-rc1-SNAPSHOT successfully with Limetrans.

fsteeg commented 2 years ago

+1, tested feature-5.3.1-rc1-SNAPSHOT with the metafacture-fix, metafacture-playground and oersi-etl builds, updated Wiki instructions for Leiningen builds (used in metafacture-playground).

dr0i commented 2 years ago

Released, see https://repo1.maven.org/maven2/org/metafacture/metamorph/5.3.1/ and https://github.com/metafacture/metafacture-core/releases/tag/metafacture-core-5.3.1. Closing.