metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.
https://metafacture.org
Apache License 2.0
69 stars 34 forks source link

Close LineRecorder receiver's stream when closing LineRecorder #433

Closed dr0i closed 2 years ago

dr0i commented 2 years ago

This came up in https://github.com/metafacture/metafacture-playground/issues/25#issuecomment-995795261:

Processing a flux pipeline results in empty data when doing this e.g. with the metafacture-playground, while it works fine when processing it using standalone metafacture-core. The cause is probably: if the JVM is stopped after processing the streams of the receivers are closed automatically, thus the data is output correctly, while an unstopped JVM (like with metafacture-playground) doesn't close all streams properly (in some cases). Here it is the LineRecorder which doesn't close its receiver.