search

metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.
https://metafacture.org
Apache License 2.0
69 stars 34 forks source link

Remove parameter "prettyPrinting" #446

Closed dr0i closed 2 years ago

dr0i commented 2 years ago

See https://github.com/metafacture/metafacture-documentation/issues/19.

blackwinter commented 2 years ago

IMO, the better solution would be to deprecate the setter and then ignore deprecated setters in HelpPrinter (or even mark them as deprecated in the documentation).

dr0i commented 2 years ago

Hm, you are right. Why not just leave it as it is?

blackwinter commented 2 years ago

Why not just leave it as it is?

What do you mean? I thought the idea was to remove (or somehow hide) the setter so that the Flux command wouldn't have to be updated manually every time the documentation is generated (metafacture/metafacture-documentation#20).

dr0i commented 2 years ago

I mean, the pretty printing parameter doesn't harm. It does just nothing. Why bother?

blackwinter commented 2 years ago

I mean, the pretty printing parameter doesn't harm. It does just nothing. Why bother?

Okay, I see. Should that be discussed in metafacture/metafacture-documentation#19?

dr0i commented 2 years ago

Closed in favour of https://github.com/metafacture/metafacture-core/pull/447.