search

metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.
https://metafacture.org
Apache License 2.0
69 stars 34 forks source link

Add github action "publish to github packages" #473

Closed dr0i closed 1 year ago

dr0i commented 1 year ago

By pushing to a "publish" branch this branch will be build and published to github packages.

See metafacture-fix#265.

dr0i commented 1 year ago

Todo: update documentation in the wiki.

fsteeg commented 1 year ago

I'm a bit confused here. The version is feature-publish-SNAPSHOT (see package). Do we actually want an unspecific snapshot release? Even if we do, I don't think we'll be able to publish that version again, I think we'll have to (manually?) delete all the packages before we can publish again with the same version.

Before, I had it set up (not in master, I used these only for OERSI) to release only when we push to an RC branch, and use that simple branch name as the version. See https://github.com/metafacture/metafacture-core/commit/6613de93e1ee1a49198ad5f837c68bc992bf0a30 (based on the original setup in https://github.com/metafacture/metafacture-core/commit/8d762ea428d41b26bf4dc64b7cc229d91793b19a). Resulting in versions like 5.3.3-rc2 (see package).

blackwinter commented 1 year ago

I'm a bit confused here. The version is feature-publish-SNAPSHOT (see package). Do we actually want an unspecific snapshot release?

TBH, I wasn't expecting this either, but it's a side effect of the "sophisticated" version logic in metafacture-core. My suggestion would be to drop it and simply rely on explicit version numbers (as in metafacture-fix).

dr0i commented 1 year ago

Thx @fsteeg , cherry-picked your solution. Published metafacture-core-5.4.1-rc1 to GitHub packages. See https://github.com/metafacture/metafacture-core/wiki/Maintainer-Guidelines#release-candidate how to do it.