metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.
https://metafacture.org
Apache License 2.0
71 stars 34 forks source link

Bugfix release or RC #481

Closed fsteeg closed 1 year ago

fsteeg commented 1 year ago

With two recent fixes that are critical for our usage in OERSI (https://github.com/metafacture/metafacture-core/pull/477, https://github.com/metafacture/metafacture-core/pull/480) it would be great to have a bugfix release or RC (GitHub packages would do for us), after #480 is merged.

blackwinter commented 1 year ago

:+1:

fsteeg commented 1 year ago

I've pushed to the 5.5.1-rc1 branch to make it available for testing via GitHub packages (version: 5.5.1-rc1, I've removed the -SNAPSHOT required for sonatype in the branch).

blackwinter commented 1 year ago

:+1: Ran both Metafix and Limetrans tests with 5.5.1 RC1. :heavy_check_mark:

dr0i commented 1 year ago

Perfect ! Can we close then?

fsteeg commented 1 year ago

Can we close then?

GitHub packages are enough for me, so +1 from that perspective.

If it was trivial to do, a bugfix release to central would be nice too (for non GitHub-package users).

dr0i commented 1 year ago

Released into Sonatype's Snapshot Repository.

release to central would be nice too

Snapshots (and rc's) should not be released to Maven Central but into a dedicated Snapshot repository - see /wiki/Maintainer-Guidelines#consume-the-snapshot how to consume it. Improved the wiki/Maintainer-Guidelines.

fsteeg commented 1 year ago

I didn't mean to release the RC to central, but the actual 5.5.1 release.

dr0i commented 1 year ago

I see. But is this neccessary? We did a release just two weeks ago and would have to go through all the hassle (writin blog post etc.). We agreed (?) to do this roughly quarterly. I agree to not slavishly stick to this time frame, e.g. there may be urgent security updates needed. So is this urgent , does it block you/others?

fsteeg commented 1 year ago

I see. But is this neccessary? [...] would have to go through all the hassle

No, it's not neccessary, that's why I wrote:

If it was trivial to do, a bugfix release to central would be nice too