metafacture / metafacture-core

Core package of the Metafacture tool suite for metadata processing.
https://metafacture.org
Apache License 2.0
69 stars 34 forks source link

Write valid leader without counting #527 #547

Open TobiasNx opened 1 week ago

TobiasNx commented 1 week ago

Instead of just appending the incoming leader elements by encode-marcmxl, this adds the static values for Pos: 00-04, 10-16, 20-23.

By using 0as default value for Pos: 00-04 and 12-16.

https://github.com/metafacture/metafacture-core/issues/527#issuecomment-2076585889

blackwinter commented 1 week ago

What's the point of doing the "easy" solution now that we already have the "hard" solution?

TobiasNx commented 1 week ago

The leader is always valid?

TobiasNx commented 1 week ago

I will put this on hold, the failing test hints that it is not as easy: issue336_createRecordWithTopLevelLeader_defaultMarc21Xml