Open TobiasNx opened 3 months ago
Idea for tests
With and without 'ensureCorrectMarc21Xml="true"'
And out oersi scenario. And perhaps some kind of manipulation of existing marc records.
I get that the marc:leader
has to be the first element and implemented that in #549.
I don't get your second comment "Idea for tests", though. Especially, the marc:leader
has just always to be emitted first - which it does with #549 , regardless of the setting of ensureCorrectMarc21Xml="true"
.
Have a look @TobiasNx after your vacation.
Did the functional review together with @maipet . Looks good, structurally, but indentation is not pretty. As this is merely an aesthetic thing we will build the new release upon this. Opened https://github.com/metafacture/metafacture-core/issues/550.
Nothing to do here. Closing.
This scenario outputs the leader wrong as part of the record tag.
IS: <marc:record t<marc:leader>00000naa a2200000uc 4500</marc:leader>ype="Bibliographic">
SHOULD BE:
<marc:record type="Bibliographic">
<marc:leader>00000naa a2200000uc 4500</marc:leader>
It seems that type is its own top-level element coming out of handle-marcxml
---
type: "Bibliographic"
leader: "00000naa a2200000uc 4500"
An additional note while the position of the leader element is fixed (with minor error when a type statement is given)
This ticket should have suggested that the orders matters not only with the leader but with the data and control fields too:
In part fixed with #558. Other than discussed at our meeting today I pledge for opening a new issue re. https://github.com/metafacture/metafacture-core/issues/548#issuecomment-2352333717. There should be a link to a playground example that shows the problem. Could you do that @TobiasNx ?
With the last release
encode-marcxml
outputs the leader as last element, it should be the first. See: https://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd