Closed TobiasNx closed 4 months ago
functional review: @TobiasNx code review: ?
As discussed today we will ask if @Phu2 has time to give it a try.
Note to self: the docs are published as github pages already, see https://metafacture.github.io/metafacture-documentation/ However, the metafacture site oddly links to the (this!) repo of the docs instead.
Note to self: the docs are published as github pages already, see https://metafacture.github.io/metafacture-documentation/ However, the metafacture site oddly links to the (this!) repo of the docs instead.
This is due to the fact that the gh pages version is not ready yet / did not exist yet and the documentation repo was used instead.
First draft is published at https://phu2.github.io/metafacture-documentation/ Still need to adjust the navigation and tweak some colors. The site will be re-deployed on push to the master branch of https://github.com/Phu2/metafacture-documentation
Structure: General pages:
FLUX
FIX
Java Integration
For Developers
Pages restructered, navigation added. @TobiasNx You might want to review the redeployed docs https://phu2.github.io/metafacture-documentation/
README.md
is left as is for use within the repoREADME.md
were copied to index.md
(Home), flux.md
, fix.md
and so onLICENSE
file is replicated as LICENSE.md
for display within the jekyll siteTODOs:
If we are done with this, we could invite the team to have a look at this.
Done. I also tried to fix all links and added a footer.
"Approaching a transformation with metafacture" isn't linked to anywhere (and has no heading). Same with "Maintainer Guide".
'Short cheer here - this looks so much better :+1:
Perhaps add the word documentation under the logo in the corner?
Also any way to turn [!NOTE] into
Seems like there is a way within justthedocs: https://just-the-docs.com/docs/ui-components/callouts/
Also how should we proceed?
New branch https://github.com/metafacture/metafacture-documentation/tree/28-use-jekyll-theme created + corresponding Github Action (on push) for deployment to http://metafacture.github.io/metafacture-documentation/
Still open merge this with master.
Add a new README.md that links to the documentation and to the markdown pages. Perhaps we should talk to @dr0i and @fsteeg if they are okay with the remodelling of the documentation repo.
The page at http://metafacture.github.io/metafacture-documentation/ looks good to me, but the PR at https://github.com/metafacture/metafacture-documentation/pull/43 is still a draft and has not been reviewed (and is not linked to this issue). Shouldn't this go through the regular review process?
The page at http://metafacture.github.io/metafacture-documentation looks good to me, but the PR at #43 is still a draft and has not been reviewed (and is not linked to this issue). Shouldn't this go through the regular review process?
I opened an PR for this and assigned you for review.
This seems to be a good option. Changing the blue to the metafacture blue otherwise nice simple documentation form.
https://just-the-docs.github.io/just-the-docs/
It allows for searching and a sidebar.
This page shows how to use this template in github pages: https://github.com/just-the-docs/just-the-docs-template/blob/main/README.md