search

metafacture / metafacture-fix

Work in progress towards an implementation of the Fix language for Metafacture
Apache License 2.0
6 stars 2 forks source link

Generating new arrays with `$append`/`$prepend` #127

Closed TobiasNx closed 1 month ago

TobiasNx commented 2 years ago

We should reintroduce $append and $prepend as creation methods if the array does not exist in a record to add to or create an array.

Was part of: https://github.com/metafacture/metafacture-fix/issues/111 Related to: #93 and #92

fsteeg commented 2 years ago

Will revisit after #102.

Functional review: @TobiasNx Code review: @blackwinter / @fsteeg

TobiasNx commented 2 years ago

Since this is standard behaviour of Catmandu fix I would like when this gets prioritized over other fix tickets.

blackwinter commented 1 year ago

Integration tests:

TobiasNx commented 2 months ago

It seems that this would "only" need adjustment in two code segments, but I could be wrong:

https://github.com/metafacture/metafacture-fix/blob/55617299f2a8e203ffc6816cbce96c7a57416eb6/metafix/src/main/java/org/metafacture/metafix/FixPath.java#L173-L175

https://github.com/metafacture/metafacture-fix/blob/55617299f2a8e203ffc6816cbce96c7a57416eb6/metafix/src/main/java/org/metafacture/metafix/FixPath.java#L342-L345

fsteeg commented 1 month ago

Ready for functional review in branch 127-arrays.

fsteeg commented 1 month ago

Changes in PR should be done, could you test again with current branch 127-arrays?

TobiasNx commented 1 month ago

I tried lobid-resources and all tests did run trough without changes +1