search

metafacture / metafacture-fix

Work in progress towards an implementation of the Fix language for Metafacture
Apache License 2.0
6 stars 2 forks source link

Add uri_encode (#273) #314

Closed dr0i closed 1 year ago

dr0i commented 1 year ago

Use metamorph's URLEncoder for uri_encode.

Supersedes https://github.com/metafacture/metafacture-fix/pull/285.

blackwinter commented 1 year ago

Would you also document this new function in the README?

dr0i commented 1 year ago

Updated the README.

blackwinter commented 1 year ago

Now we're entering shaky territory ;) We differentiate between "record-level" and "field-level" methods. You placed the implementation in the latter section, but the documentation in the former. I don't think we have clear criteria for which is which (@fsteeg, @TobiasNx?), but this one is almost definitely "field-level" I would say (so the documentation should match the implementation).

dr0i commented 1 year ago

No, makes sense. Wasn't aware of two sections. Moved docu snippet to the proper place. Please have a look again.

blackwinter commented 1 year ago

Sorry, but now it's in "script-level" ;) I've moved it down in ~db84fb7~b3420ec.

dr0i commented 1 year ago

Ahhh - I put it into Script-level functions ... will fix that.

blackwinter commented 1 year ago

And I named the wrong section in the commit message :( Probably started the weekend a little early ;)

Fixed it in b3420ec and force-pushed. Hope that's okay.

dr0i commented 1 year ago

Hope that's okay.

timely :) Going to merge now.