metafates / mangal

📖 The most advanced (yet simple) cli manga downloader in the entire universe! Lua scrapers, export formats, anilist integration, fancy TUI and more!
MIT License
1.27k stars 51 forks source link

Can't change downloader.path #156

Open czervick212 opened 1 year ago

czervick212 commented 1 year ago

Describe the bug

mangal config set --key downloader.path --value "/Users/xxxxxxx" is not changing the download path on mac, all pdf's are going to: /private/var/folders/hz/w6wc2p3x645dzvnh3dryxsxc0000gn/T/mangal

Not sure why I can't get the download path to stick.

Reproduction steps

  1. input: mangal config set --key downloader.path --value "location"
  2. input: mangal config write
  3. search for and download a manga
  4. Manga does not go to inputted location
  5. Manga is saved in /private/var/folders/hz/w6wc2p3x645dzvnh3dryxsxc0000gn/T/mangal

Expected behavior

  1. input: mangal config set --key downloader.path --value "location"
  2. input: mangal config write
  3. search for and download a manga
  4. Manga is in the set location

Additional context

Could be user error but I tried editing the TOML file as well and still couldn't get it to download in the right place.

When I check 'mangal env' it shows MANGAL_DOWNLOADER_PATH as unset, not sure if that has anything to do with it.

Operating System

macOS

metafates commented 1 year ago

Hi!

Do you download manga by selecting it with space and then pressing enter ? By default, pressing enter with no selection OR pressing r would download manga into the temp directory and open it for reading only.

Could you provide the output for this command?

mangal config info -k downloader.path
czervick212 commented 1 year ago

Ah, yes, not pressing space was causing the problem. Is there a way to edit that behavior on my end? Enter feels more intuitive for me. Thanks!

Here is the output for that command:

XXXXXXXX ~ % mangal config info -k downloader.path
Where to download manga                                                         
Absolute or relative.                                                           
You can also use tilde (~) to refer to your home directory or use env variables.
Examples: ~/... or $HOME/... or ${MANGA_PATH}-mangal                            
Key:     downloader.path
Env:     MANGAL_DOWNLOADER_PATH
Value:   /Users/XXXX/Documents/Manga
Default: .
Type:    string% 
metafates commented 1 year ago

Sureee, I can add an option to alter this behavior