search

metafizzy / flickity-fade

Fade between Flickity slides
62 stars 18 forks source link

Flickity 2.3 + Fade 2.0 #17

Open anteksiler opened 2 years ago

anteksiler commented 2 years ago

Using flickity.pkgd.min.js + fade script throws the following error:

Cannot set properties of undefined (setting 'fade')

Test case: https://codepen.io/anteksiler/pen/QWadjXP

AnInfiniteNumberofMonkeys commented 2 years ago

I'm getting this too. It also happens with Flickity 2.2 + Face 2.0

ewhicher commented 2 years ago

Same here too, using latest package links:

<script src="https://unpkg.com/flickity@2/dist/flickity.pkgd.min.js"></script>
<script src="https://unpkg.com/flickity-fade@2/flickity-fade.js"></script>
mark-chief commented 2 years ago

Same for me..

    <link rel="stylesheet" href="https://unpkg.com/flickity@2/dist/flickity.min.css">
    <link rel="stylesheet" href="https://unpkg.com/flickity-fade@2/flickity-fade.css">
    <script src="https://unpkg.com/flickity@2/dist/flickity.pkgd.min.js"></script>
    <script src="https://unpkg.com/flickity-fade@2/flickity-fade.js"></script>
troycartmill commented 2 years ago

I'm getting same error. I'm using Flickity v2.2.1 + Face 2.0

darinronne commented 2 years ago

I am also experiencing this issue. Fade v1 works with Flickity v2.2 and v2.3, but Fade v2 works with neither version of Flickity.

anteksiler commented 2 years ago

Fade v1 is not working for me with Flickity 2.3

anteksiler commented 2 years ago

@desandro Hi David, could you please look into this? I am not sure what the issue is.

atlamors commented 2 years ago

+1

RYJASM commented 2 years ago

I am having this same issue.

oxwebdevelopment commented 2 years ago

+1

Retroguru commented 1 year ago

Same here. Would be nice to fix this :-)

alphex commented 1 year ago

Downgrading to Flickity 2.2.0 with the Flickity-fade 1.0.0 release worked to solve the issue for me on a new build.

The release tags for flickity-fade say 2.0 is for the flickity 3 release. (see: https://github.com/metafizzy/flickity-fade/releases/tag/v2.0.0) 

v2.0.0 for Flickity v3
ewhicher commented 1 year ago

@desandro any idea if you will be able to look at this any time soon?

Thanks!

martinlandmeters commented 1 year ago

+1

IndoPy commented 1 year ago

+1

mhuegel commented 1 year ago

+1 but the solution from @alphex helped!

dsoriano commented 1 year ago

Use fade v1 with filckity v2 :

<script src="https://unpkg.com/flickity@2/dist/flickity.pkgd.min.js"></script>
<script src="https://unpkg.com/flickity-fade@1/flickity-fade.js"></script>

And don't forget not to use the wrapAround function, it works bad with it.