metafizzy / flickity-fade

Fade between Flickity slides
62 stars 18 forks source link

Fade issue with negative progress #19

Closed odessy closed 2 years ago

odessy commented 2 years ago

Should the progress variable be abs to prevent a case where it may be negative. This would result in 1 - (- progress) a value greater than 1.

https://github.com/metafizzy/flickity-fade/blob/213fec88d04539b32ae15998166f364815f7f5fe/flickity-fade.js#L144

I don't have exact steps to replicate this issue but this was the outcome after tracing the issue a -progress.

odessy commented 2 years ago

same as https://github.com/metafizzy/flickity-fade/issues/1