search

metafizzy / flickity-fade

Fade between Flickity slides
62 stars 18 forks source link

When using asNavFor, fade stops working (Webpack) #8

Open dungle-scrubs opened 5 years ago

dungle-scrubs commented 5 years ago

Hi, I'm using webpack and when I attempt to use flickity-fade with flickity-as-nav-for, fade breaks and it reverts back to a swipe.

When I remove flickity-as-nav-for, fade starts working again.

Thanks

desandro commented 5 years ago

This sounds like a structure issue with Flickity. Currently add-ons like flickity-fade and flickity-as-nav-far use flickity as a dependency, but it should be a peerDependency to resolve issues like this one.

Sorry I don't have a good solution here. Ideally both flickity-face and flickity-as-nav-for should be loading and adding on to the same Flickity instance. I don't have Webpack expertise so I'm not sure how to resolve this.

dungle-scrubs commented 5 years ago

Thanks for taking a look desandro, I'll continue to play around with it and update if I find a solution.

plucile commented 4 years ago

And luck fixing this @dungle-scrubs? I'm having the same issue

addedlovely commented 3 years ago

Overriding the CSS with the CSS animation outlined here https://github.com/metafizzy/flickity-fade/issues/4 seems to resolve the issue.