search

metafizzy / flickity-fullscreen

Enable fullscreen view for Flickity carousels
46 stars 17 forks source link

Add [type=button] to the [flickity-fullscreen-button] #18

Closed jstnrs closed 5 years ago

jstnrs commented 6 years ago

When the slider and thus the button to activate is within a form element, the button now submits the form. When adding type="button" to the (open and close) buttons, this would not be the case.

jstnrs commented 6 years ago

I've opened a Pull request here with a fix, which is also used in the Flickity sources (https://github.com/metafizzy/flickity/blob/master/js/prev-next-button.js#L58): https://github.com/metafizzy/flickity-fullscreen/pull/19

desandro commented 6 years ago

Ah! Thanks for catching this and submitting a PR. The PR has been Merged! This will be a part of the next release 🌈🐻

desandro commented 5 years ago

Released in flickity-fullscreen v1.1.1