search

metafizzy / flickity-fullscreen

Enable fullscreen view for Flickity carousels
46 stars 17 forks source link

Pinch to zoom not working on Android/Chrome #20

Open winzig opened 6 years ago

winzig commented 6 years ago

When you load a flickity image fullscreen using this module, on Android/Chrome, pinch-to-zoom is not working. It works fine on iOS, however. It also works on Android in the Samsung Internet Browser app. I am able to reproduce this using the fullscreen demo here.

Is this a known issue, or should I keep digging further?

desandro commented 6 years ago

Thanks for reporting this issue. I'll have to take on an Android device. Can you report what version of Chrome you are using?

winzig commented 6 years ago

@desandro Chrome 65.0.3325.109, thanks

winzig commented 6 years ago

Currently running Android 8.1, but I was also reproducing it a few days ago on 8.0, FWIW.

smickar commented 5 years ago

Try in javascript change touchActionValue="pan-y" to touchActionValue="pan-y pinch-zoom", it helped me.

ptrsmk commented 5 years ago

I ran into this as well. Pinch-to-zoom fails on fullscreen using a variety of browsers on Android 10, Pixel 2.

canonicalized commented 4 years ago

Try in javascript change touchActionValue="pan-y" to touchActionValue="pan-y pinch-zoom", it helped me.

Thanks a latte!

jibinycricket commented 4 years ago

Try in javascript change touchActionValue="pan-y" to touchActionValue="pan-y pinch-zoom", it helped me.

Where would you do this?

aariacarterweir commented 4 years ago

To change default for all uses of flickity: Flickity.prototype._touchActionValue = 'pan-y pinch-zoom';

(do this before instantiating of course)

spacecat commented 3 years ago

Any updates on this one?

PS. n._touchActionValue="pan-y pinch-zoom" did not work for me on my Samsung Galaxy S8. I'm using:

Chrome 86.0.4240.198 Android 9

PPS: Seems to be working now. Caching issue.

Will this change break anything else?

dpw1 commented 3 years ago

To change default for all uses of flickity: Flickity.prototype._touchActionValue = 'pan-y pinch-zoom';

(do this before instantiating of course)

It works on the latest Flickity's version. Thanks.