search

metafizzy / flickity-fullscreen

Enable fullscreen view for Flickity carousels
46 stars 17 forks source link

Set flickity as peerDependecy #26

Open emateu opened 5 years ago

emateu commented 5 years ago

Scenario

Combining flickity with multiples plugins, like flickity-fullscreen and flickity-as-nav-for.

Issue

Since we have flickity as a dependency, will extend flickity from it's own node_modules instead of extending the one of the project's node_modules.

This makes impossible to combine two plugins.

Solution

Define on the plugin, flickity as a peerDependency.

--

If you merge this, we should do the same on https://github.com/metafizzy/flickity-as-nav-for