search

metafizzy / flickity-fullscreen

Enable fullscreen view for Flickity carousels
46 stars 17 forks source link

Major glitches when you try to change fullscreen status when the carousel is moving #32

Open nkalupahana opened 2 years ago

nkalupahana commented 2 years ago

If you go the demo, click the next button on the carousel, and then immediately click the fullscreen button, instead of seeing the fullscreen carousel, you'll see a black image. Similarly, if you drag the carousel while it's in fullscreen and then click the button to exit, the carousel image will disappear.

This bug makes this functionality unusable, and any insight into why it might be happening would be greatly appreciated.

AndreasDeRijcke commented 2 years ago

I confirm both the issue and the patch having the desired result.

txrris commented 2 years ago

This is NOT fixed, issue is still present on the demo

nkalupahana commented 2 years ago

@txrris Yes, it is not -- that's what PR #33 is for, which hopefully will eventually get merged :/ Until then, feel free to use my fork of the package, which has the fix.

Alexandre-dcm commented 2 years ago

Thx a lot for the fix @nkalupahana

mattneal-stafflink commented 1 year ago

Any updates on this? The problem still exists.