search

metafizzy / outlayer

:construction_worker: the brains & guts of a layout library
163 stars 63 forks source link

isTransitioning remains true on dynamically added elements #23

Closed joshuahiggins closed 9 years ago

joshuahiggins commented 9 years ago

I originally posted this as metafizzy/packery#216, before realizing the issue was part of Outlayer.

Dynamically appended elements are given the isTransitioning attribute due to their reveal. However, there is currently no check or callback for when the reveal animations end to remove this attribute. This causes a conflict with the _transitionTo function, as the property is set when it shouldn't be, preventing the 'layout' event from properly broadcasting for dynamic elements.

desandro commented 9 years ago

Thank you for reporting this issue. Could you help me out and put together a little demo that demonstrates the problem? You can fork the Packery appended demo on CodePen

joshuahiggins commented 9 years ago

I'm closing this. The issue came up while working with dynamically rendered directives in Angular, as I'm currently writing an Angular wrapper for Packery. After spending the last hour poking around on a fork in CodePen, I realized that the issue has to do with when Angular fires off the $includeContentLoaded on ng-include partials, not Outlayer or Packery. It appears to fire after the content is loaded, but before the DOM renders it. This is the true root of the issue I am experiencing.

desandro commented 9 years ago

Thanks for following up!