search

metafizzy / outlayer

:construction_worker: the brains & guts of a layout library
163 stars 63 forks source link

Critical Bug in #21 #25

Closed maimairel closed 9 years ago

maimairel commented 9 years ago

Please see my comment on PR #21, there is a critical bug there that better don't make into the next release.

Thanks!

TeaSeaLancs commented 9 years ago

Thanks for spotting this, I think I realised the problem that caused me to make this mistake :S I tend to work a lot with local copies of libraries and merge into git afterwards due to the projects I work on, but in this case I must have got flustered and badly transcribed it instead of merged it.

I've submitted a fresh pull request which fixes this issue, hopefully @desandro will be able to merge it in before the next release.

maimairel commented 9 years ago

@TeaSeaLancs Thank you, I'm glad you started the pull request as that helped me to sort this out too :)

desandro commented 9 years ago

Fixed in #26. Thanks for catching this! :baseball: