Closed danofames closed 8 years ago
Thank you for this contribution. Item now checks for the property to watch so it can trigger transition end callback in getHideRevealTransitionEndProperty. I've left this PR open for a while in case others were interested. Time to close it up :strawberry:
That the
hiddenStyle
option needs a declaration that actually hides the card is more obvious in hindsight, but it was unexpected to me that overridinghiddenStyle
led to the items remaining visible after they were filtered by theisotope.filter
call.This change was an approach that fixes that behavior, and seemed to have minimal impact. It is suboptimal that the handler would execute for any properties in
hiddenStyle
.The unexpected nature could be solved by a note in documentation.
I could also see removing the
onTransitionEnd
handler inItem.hide
, and leave the hiding of the item up to thehiddenStyle
option completely. Part of the confusion is that the items are hidden without any overrides tohiddenStyle
. As default behavior, this should occur unless a specific request to prevent the hiding after the transition is done is made.